RFR: JDK-8157100: missing dependency in build system

Erik Joelsson erik.joelsson at oracle.com
Wed Aug 3 15:26:41 UTC 2016


Hello,

When making changes to this file:

langtools/src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties

The incremental build fails to recognize the change and rebuild 
properly. The problem is a missing $ in a macro definition. I have 
verified this fix with the reproducer presented in the bug.

Bug: https://bugs.openjdk.java.net/browse/JDK-8157100

Patch:

diff -r a8dde57edb12 make/gensrc/GensrcCommon.gmk
--- a/make/gensrc/GensrcCommon.gmk
+++ b/make/gensrc/GensrcCommon.gmk
@@ -117,7 +117,7 @@
      $$(addprefix _SPACE_, $$(PARSEPROPALLDIRS))))

    # Now setup the rule for the generation of the resource bundles.
-  $(SUPPORT_OUTPUTDIR)/gensrc/$(MODULE)/_the_parsed_props: 
$(PARSEPROPSOURCES)
+  $(SUPPORT_OUTPUTDIR)/gensrc/$(MODULE)/_the_parsed_props: 
$$(PARSEPROPSOURCES)
      $(MKDIR) -p $$(@D) $$(PARSEPROPDIRS)
      $(FIND) $$(@D) -name "*Properties.java" $(FIND_DELETE)
      $(ECHO) Parsing $$(words $$(PARSEPROPSOURCES)) properties into 
enum-like class for $(MODULE)

/Erik




More information about the build-dev mailing list