RFR: JDK-8164402 key word 'requires' appearing in comment causing a build failure

David Holmes david.holmes at oracle.com
Fri Aug 19 07:26:02 UTC 2016


Hi Tim,

Fix seems reasonable but this seems a rather crude way to determine 
dependencies.

Thanks,
David

On 19/08/2016 4:05 PM, Tim Bell wrote:
> Hello
>
> Earlier today a javadoc change surprised us by causing JDK 9 builds to
> fail on all platforms, due to a modules 'requires' statement error.
>
> The fix is to have make/common/Modules.gmk be more selective when
> processing 'requires', so that comment lines are filtered out.
>
> Here is the bug report:
> https://bugs.openjdk.java.net/browse/JDK-8164402
>
> And the webrev:
> http://cr.openjdk.java.net/~tbell/8164402/webrev/
>
> Thanks in advance-
>
> Tim



More information about the build-dev mailing list