RFR: JDK-8056215 AWT source dirs should only point to java2d, not below

Erik Joelsson erik.joelsson at oracle.com
Thu Dec 1 13:38:16 UTC 2016


Looks good.

/Erik


On 2016-12-01 12:42, Magnus Ihse Bursie wrote:
> On 2016-11-28 11:01, Erik Joelsson wrote:
>> It looks like this will result in the same files being built, but 
>> just to be sure, have you verified the result to be equal?
> I thought I had done that, but it turned out I used an incorrect 
> command line so I didn't verify anything. A proper verification made 
> some problems with include files surface. I have now fixed them, and 
> verified-honest-to-god that it is correct. :)
>
> New webrev: 
> http://cr.openjdk.java.net/~ihse/JDK-8056215-cleanup-awt-src-dirs/webrev.02
>
> I have sorted the include files fully according to the principle: 
> <this lib>, <common>, <other libs>.
>
> /Magnus
>
>>
>> /Erik
>>
>>
>> On 2016-11-28 10:47, Magnus Ihse Bursie wrote:
>>> This is from a code review following the jigsaw source file 
>>> restructuring:
>>>
>>> * The makefiles include too specific directories. Instead of 
>>> including e.g. ./*/native/common/sun/java2d/opengl and 
>>> ./*/native/common/sun/java2d/x11, we should just include 
>>> ./*/native/common/sun/java2d. This level corresponds to a logical 
>>> grouping of the source code, and not the directory structure in that 
>>> grouping.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8056215
>>> WebRev: 
>>> http://cr.openjdk.java.net/~ihse/JDK-8056215-cleanup-awt-src-dirs/webrev.01
>>>
>>> /Magnus
>>
>




More information about the build-dev mailing list