RFR: JDK-8076577 Do not allow ccache prior to 3.2 on macosx

Tim Bell tim.bell at oracle.com
Fri Dec 2 15:01:30 UTC 2016


Magnus:

Looks good to meas well.

/Tim


On 12/02/16 06:34, Erik Joelsson wrote:
> Looks ok.
>
> /Erik
>
>
> On 2016-12-02 15:15, Magnus Ihse Bursie wrote:
>> On macosx, ccache prior to 3.2 does not work properly. We should
>> detect this during configure.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8076577
>> Patch inline:
>> diff --git a/common/autoconf/build-performance.m4
>> b/common/autoconf/build-performance.m4
>> --- a/common/autoconf/build-performance.m4
>> +++ b/common/autoconf/build-performance.m4
>> @@ -217,6 +217,13 @@
>>  AC_DEFUN([BPERF_SETUP_CCACHE_USAGE],
>>  [
>>    if test "x$CCACHE" != x; then
>> +    if test "x$OPENJDK_BUILD_OS" = "xmacosx"; then
>> +      HAS_BAD_CCACHE=[`$ECHO $CCACHE_VERSION | \
>> +          $GREP -e '^1\.' -e '^2\.' -e '^3\.0\.' -e '^3\.1\.'`]
>> +      if test "x$HAS_BAD_CCACHE" != "x"; then
>> +        AC_MSG_ERROR([On macosx, ccache 3.2 or later is required,
>> found $CCACHE_VERSION])
>> +      fi
>> +    fi
>>      if test "x$USE_PRECOMPILED_HEADER" = "x1"; then
>>        HAS_BAD_CCACHE=[`$ECHO $CCACHE_VERSION | \
>>            $GREP -e '^1.*' -e '^2.*' -e '^3\.0.*' -e '^3\.1\.[0123]$'`]
>>
>> /Magnus
>




More information about the build-dev mailing list