[9] RFR(XL) 8166417: Integrate Graal-core into JDK for AOT compiler

Mandy Chung mandy.chung at oracle.com
Fri Dec 9 16:40:04 UTC 2016


> On Dec 8, 2016, at 11:07 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
> 
>> 
>> The new syntax for provides is to have one `provides` clause of the same SPI
>> with comma-separated implementation classes (see [1] for reference)
> 
> Previous loop in this makefile also produces multiple `provides` of the same SPI. I fixed it too. The output is next for example:
> 
> provides org.graalvm.compiler.hotspot.CompilerConfigurationFactory with
>    org.graalvm.compiler.hotspot.CoreCompilerConfigurationFactory,
>    org.graalvm.compiler.hotspot.EconomyCompilerConfigurationFactory,
>    ;
> 
> Looks like build tools excepts ; after ,
> If you are fine with it I will make this change.

It’s a bug in the build tool and I will file a bug. 

Is it easy to drop last comma?  If not, we could fix this makefile when the build tool is fixed.

Mandy


More information about the build-dev mailing list