correct version of the autoconf tools?

[Erik Joelsson]

Hello,

2.69 is the version we require. However, the latest Ubuntu release has a 
different 2.69 bundled, where they cherry picked some changes from 
upstream, without changing the version string. The runstatedir stuff is 
part of that.

Personally I sometimes include the generated file in my webrev and 
sometimes not. It's quite big so saves a bit of upload time if excluded. 
I very rarely look at it while reviewing. It's assumed to be correctly 
generated.

/Erik


On 2016-12-19 11:15, Thomas Stüfe wrote:
> Hi all,
>
> What is the correct version of the autoconf tools to use when regenerating
> generated-configure.sh?
>
> I am generating with autoconf 2.69 and get a number of diffs unrelated to
> my change, among others:
>
> +  -runstatedir | --runstatedir | --runstatedi | --runstated \
> +  | --runstate | --runstat | --runsta | --runst | --runs \
>
> etc. I see option runstatedir has been removed in "8166937: [Solaris]
> Missing libjvm_db.so and libjvm_dtrace.so from JDK 9 b138". Was that
> delibarate? Am I using the wrong autoconf?
>
> Or, asked another way, should I even care? When providing webrevs for
> changes in m4 files, should I also provide an updated configure script? And
> if yes, should it only diff minimally?
>
> Thank you!
>
> Thomas