RFR(xs): 8171433: [aix] switch on gtest AIX build
Volker Simonis
volker.simonis at gmail.com
Tue Dec 20 08:28:11 UTC 2016
Hi Thomas,
the change looks good.
Thanks for finally getting gtest to work on AIX!
And thank you David for sponsoring.
Regards,
Volker
On Tue, Dec 20, 2016 at 5:35 AM, Thomas Stüfe <thomas.stuefe at gmail.com> wrote:
> Great, David, please push them all for me.
>
> The TOC overflow one (8171408) is the only non trivial IMHO and I'd like
> Volker to take a second look.
>
> Thanks, Thomas
>
>
> On Dec 20, 2016 04:18, "David Holmes" <david.holmes at oracle.com> wrote:
>
>> Looks fine. I can sponsor this for you once the other changes have been
>> pushed. Or I can push them altogether for you.
>>
>> David
>>
>> On 19/12/2016 11:26 PM, Thomas Stüfe wrote:
>>
>>> Hi all,
>>>
>>> Please review this tiny change.
>>>
>>> Note that this was already part of the review of 8171225. I decided to
>>> split that patch into multiple patches. This patch here just switches on
>>> building of gtest on AIX by default (it was disabled due to build errors
>>> before).
>>>
>>> Issue: https://bugs.openjdk.java.net/browse/JDK-8171433
>>> Webrev:
>>> http://cr.openjdk.java.net/~stuefe/webrevs/8171433-aix-switc
>>> h-on-gtest-make-by-default/webrev.00/webrev/index.html
>>>
>>> Kind Regards, Thomas
>>>
>>>
More information about the build-dev
mailing list