8149116: Make test/Makefile more silent
Mikael Vidstedt
mikael.vidstedt at oracle.com
Fri Feb 5 18:26:44 UTC 2016
Looks good, ship it!
/Mikael
On 2016-02-05 04:44, Erik Joelsson wrote:
> Looks fine by me.
>
> The -jN complaint comes from make/MainSupport.gmk where we add -j1
> when calling test/Makefile because we don't trust it to handle
> parallel make execution.
>
> /Erik
>
> On 2016-02-05 13:34, Erik Helin wrote:
>> Hi all,
>>
>> this tiny patch makes the common test targets in test/Makefile a bit
>> more silent. The patch silences the `make` command and also silences the
>> "Entering directory" output from make. For example, running
>> `make test-hotspot-internal` currently prints:
>>
>> Building target 'test-hotspot-internal' in configuration 'x64-slow'
>> make[3]: warning: -jN forced in submake: disabling jobserver mode.
>> make -k -C /home/ehelin/code/jdk9/dev/hotspot/test CONCURRENCY=1
>> TEST=hotspot_internal hotspot_internal
>> make[4]: Entering directory '/home/ehelin/code/jdk9/dev/hotspot/test'
>>
>> and with the patch applied it prints:
>>
>> Building target 'test-hotspot-internal' in configuration 'x64-slow'
>> make[3]: warning: -jN forced in submake: disabling jobserver mode.
>>
>> Unfortunately I don't know how to get rid of the warning
>> "-jN forced in submake" :( Anyway, below is the patch:
>>
>> # HG changeset patch
>> # User ehelin
>> # Date 1454675226 -3600
>> # Fri Feb 05 13:27:06 2016 +0100
>> # Node ID e0f7bec5f61d3619e78f4d1683e208012f1709f5
>> # Parent 3ca929279adbdbbe590abb727dbaf9e4a9c6bf69
>> 8149116: Make test/Makefile more silent
>>
>> diff -r 3ca929279adb -r e0f7bec5f61d test/Makefile
>> --- a/test/Makefile Fri Feb 05 09:41:16 2016 +0100
>> +++ b/test/Makefile Fri Feb 05 13:27:06 2016 +0100
>> @@ -40,8 +40,7 @@
>> define SUBDIR_TEST # subdirectory target
>> if [ -d $1 ] ; then \
>> if [ -r $1/test/Makefile ] ; then \
>> - echo "$(MAKE) -k -C $1/test $2" ; \
>> - $(MAKE) -k -C $1/test $2 ; \
>> + $(MAKE) --no-print-directory -k -C $1/test $2 ; \
>> else \
>> echo "ERROR: File does not exist: $1/test/Makefile"; \
>> exit 1; \
>>
>> Thanks,
>> Erik
>
More information about the build-dev
mailing list