[8u76] Request for review & approval for CR8146566: OpenJDK build can't handle commas in LDFLAGS

[Rob McKenna]

Approved. (not sure why I didn't explicitly state that in the last mail)

	-Rob

On 08/01/16 13:56, Andrew Hughes wrote:
> ----- Original Message -----
>> Looks good.
>>
>> /Erik
>>
>
> Thanks Erik. Pushed:
>
> http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/92c6a16b6dac
>
>> On 2016-01-06 20:12, Rob McKenna wrote:
>>> cc'ing build-dev for a review and updating the subject.
>>>
>>>      -Rob
>>>
>>> On 06/01/16 19:10, Andrew Hughes wrote:
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8146566
>>>> Webrev: http://cr.openjdk.java.net/~andrew/8u/8146566/webrev.01/
>>>>
>>>> If additional LDFLAGS containing commas are passed to the build e.g.
>>>>
>>>> --with-extra-ldflags="-Wl,--as-needed -Wl,-O1 -Wl,--hash-style=gnu
>>>> -Wl,--sort-common"
>>>>
>>>> (which are the default flags on Fedora), then the build will fail as
>>>> the call to
>>>> SetupNativeCompilation expands LDFLAGS_JDKLIB early and the commas
>>>> are interpreted
>>>> to denote separate arguments to this macro.
>>>>
>>>> On current 8u, this only affects the demo code (BUILD_DEMO_JVMTI_$1).
>>>> It did
>>>> affect both the demo code and the main JDK build on 9, and I was
>>>> planning
>>>> to submit a similar fix there. However, 8142907 was added which fixed
>>>> both cases
>>>> there, as well as introducing a number of other changes.
>>>>
>>>> For 8u, I'd like to backport the relevant part of 8142907 under this
>>>> bug, 8146566.
>>>> Without this fix, the build fails with the above option. With it,
>>>> it successfully completes. 8142907 in full contains other changes,
>>>> many specific
>>>> to Mac OS, which would introduce unnecessary changes into the 8u build.
>>>>
>>>> Ok to push this?
>>>>
>>
>>
>