RFR: JDK-8147934: Remove --with-sdk-name from macosx jib profile

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Thu Jan 21 11:07:03 UTC 2016


On 2016-01-21 11:52, Erik Joelsson wrote:
> The --with-sdk-name in the macosx profile is not needed, and will be 
> ignored. Configure complains:
>
> WARNING: Both SYSROOT and --with-sdk-name are set, only SYSROOT will 
> be used
>
> The devkit already enforces the correct sdk name through setting sysroot.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8147934
> Patch:
> diff -r f36cf7e8ba68 common/conf/jib-profiles.js
> --- a/common/conf/jib-profiles.js
> +++ b/common/conf/jib-profiles.js
> @@ -257,7 +257,7 @@
>              target_os: "macosx",
>              target_cpu: "x64",
>              dependencies: concat(common.dependencies, "devkit"),
> -            configure_args: concat(common.configure_args, 
> "--with-sdk-name=macosx10.9"),
> +            configure_args: common.configure_args,
>              make_args: common.make_args
>          },
>
Looks good to me.

/Magnus



More information about the build-dev mailing list