RFR (L) JEP 280: Indify String Concatenation (integration)

[Magnus Ihse Bursie]

On 2016-01-27 14:55, Aleksey Shipilev wrote:
> Hi again,
>
> This is a formal pre-integration review thread for JEP 280 ("Indify
> String Concatenation") integration:
>     http://openjdk.java.net/jeps/280
>
> The JEP is Targeted, the CCC is approved, the code reviews and
> pre-integration checks are clean.
>
> Code changes are happening simultaneously in four components:
>
>   a) (M) javac changes that emit indy:
>     http://cr.openjdk.java.net/~shade/8085796/webrev.langtools.05/
>
>   b) (L) JDK changes with StringConcatFactory and friends, plus fixing
> the regression tests that do not expect additional indys:
>     http://cr.openjdk.java.net/~shade/8085796/webrev.jdk.08/
>
>   c) (XS) Build changes that force emitting the "legacy" inline
> StringBuilder concat in a few cases (e.g. when pre-JDK 9 bytecode is
> expected):
>     http://cr.openjdk.java.net/~shade/8085796/webrev.root.00/

Aleksey,

Build changes look good to me.

Just out of curiosity, what does "indy" mean in this context? I have not 
heard this expression and googling fails to bring up anything relevant.

/Magnus

>
>   d) (XS) HotSpot changes that fix a GC regression test that now
> allocates some metaspace from within the test methods having a string
> concatenation:
>     http://cr.openjdk.java.net/~shade/8085796/webrev.hs.00/


>
> These changes were already reviewed by multiple people, and so I would
> like to keep the comments only for serious breaking issues at this
> point. (Note that this thread cross-posts over several mailing lists:
> bike-shedding discussion would get multiplied a lot!)
>
> Formal acknowledgements from Reviewers would be appreciated. Pending no
> show-stopper comments, I'd like to push this through jdk9/dev in 24 hours.
>
> Thanks,
> -Aleksey
>