RFR: JDK-8148120 Incremental update from build-infra project

Erik Joelsson erik.joelsson at oracle.com
Fri Jan 29 13:21:46 UTC 2016


Looks ok.

/Erik

On 2016-01-25 14:51, Magnus Ihse Bursie wrote:
> On 2016-01-25 09:13, Erik Joelsson wrote:
>> In NativeCompilation.gmk, the exit value saving for linking is most 
>> likely redundant. I managed to remove that for the compile command 
>> lines. There I verified that failed compiles still failed the build, 
>> without the need for exitvalue saving. I do believe this was relying 
>> on the -e switch to bash (I tried both with and without that and 
>> pipefail to be sure which was required), but we do have that always 
>> on windows.
>
> Aha, nice. I based the new link code on the old compile-call version, 
> and when I merged in your new updates I didn't realize that the code I 
> based it on had been simplified.
>
> Updated webrev: (only NativeCompilation.gmk changed)
> http://cr.openjdk.java.net/~ihse/JDK-8148120-incremental-updates-from-build-infra/webrev.02 
>
>
> /Magnus
>
>>
>> /Erik
>>
>> On 2016-01-24 09:56, Magnus Ihse Bursie wrote:
>>> This patch contains a series of small fixes of general applicability 
>>> that have been created in the build-infra project. These are:
>>>
>>> * Add missing llvm library dependency
>>> * Improve compare script for static libraries
>>> * Simplify LogFailures interface, and add support for storing 
>>> command lines
>>> * Hide "Creating library *.lib and object *.exp" text when linking 
>>> on Windows
>>> * Fix problems with smartjavac when using the build-compare 
>>> functionality
>>> * When repeating output, truncate it if too long
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8148120
>>> WebRev: 
>>> http://cr.openjdk.java.net/~ihse/JDK-8148120-incremental-updates-from-build-infra/webrev.01
>>>
>>> /Magnus
>>>
>>
>




More information about the build-dev mailing list