[RFR] JDK-8156980: Hotspot build doesn't have -std=gnu++98 gcc option

Kim Barrett kim.barrett at oracle.com
Thu Jul 7 19:10:34 UTC 2016


> On Jul 7, 2016, at 1:48 PM, Andrew Hughes <gnu.andrew at redhat.com> wrote:
>>> Revised webrevs:
>>> 
>>> http://cr.openjdk.java.net/~andrew/8156980/webrev.04/root
>>> http://cr.openjdk.java.net/~andrew/8156980/webrev.04/hotspot
>> 
>> These look good to me.
>> 
> 
> Minor revision:
> 
> http://cr.openjdk.java.net/~andrew/8156980/webrev.05/root
> http://cr.openjdk.java.net/~andrew/8156980/webrev.05/hotspot
> 
> I spotted that jsig is just a single C file and so doesn't
> need the -std flag. In fact, it complains about it:
> 
> Compiling jsig.c (for libjsig.so)
> ( ( /usr/bin/gcc -fPIC -D_GNU_SOURCE -D_REENTRANT -O2 -pipe -march=core2 -std=gnu++98 -m64 -g -DTHIS_FILE='"jsig.c"' -c -MMD -\
> MF /home/andrew/builder/dev/hotspot/libjsig/objs/jsig.d -o /home/andrew/builder/dev/hotspot/libjsig/objs/jsig.o /home/andrew/p\
> rojects/openjdk/upstream/dev/hotspot/src/os/linux/vm/jsig.c > >(/usr/bin/tee /home/andrew/builder/dev/hotspot/libjsig/objs/jsi\
> g.o.log) 2> >(/usr/bin/tee /home/andrew/builder/dev/hotspot/libjsig/objs/jsig.o.log >&2) || ( exitcode=$? && /bin/cp /home/and\
> rew/builder/dev/hotspot/libjsig/objs/jsig.o.log /home/andrew/builder/dev/make-support/failure-logs/hotspot_libjsig_objs_jsig.o\
> .log && exit $exitcode ) ) && wait )
> cc1: warning: command line option '-std=gnu++98' is valid for C++/ObjC++ but not for C
> 
> So just ADLC is fixed now.
> 
> The root webrev is the same as before.

Oops, glad you caught that.

Looks even better.




More information about the build-dev mailing list