[RFR] JDK-8156980: Hotspot build doesn't have -std=gnu++98 gcc option

[Kim Barrett]

> On Jul 8, 2016, at 2:38 AM, Erik Joelsson <erik.joelsson at oracle.com> wrote:
> 
> Hello,
> 
> This looks good except for the change in toolchain.m4, which looks like it might actually break cross compilation by overriding the value for compiler version for the build compiler using the target compiler. With this change we basically have:
> 
> if cross compilation
>  TOOLCHAIN_PREPARE_FOR_VERSION_COMPARISONS([BUILD_], [OPENJDK_BUILD_])
> else
>  ...
> fi
> TOOLCHAIN_PREPARE_FOR_VERSION_COMPARISONS([], [OPENJDK_BUILD_])
> 
> The problem you are trying to solve is that in the case of not cross compilation, the TOOLCHAIN_PREPARE_FOR_VERSION_COMPARISONS macro wasn't called with "OPENJDK_BUILD_". Kim's suggested patch was to add the call in the else clause.

Good catch!  I totally missed that when reviewing.