RFR: JDK-8161057 Solaris: deprecated/obsolete compiler flags should be removed

David Holmes david.holmes at oracle.com
Wed Jul 20 02:17:21 UTC 2016


Looks good Alan! Thanks for cleaning this up.

One comment below ...

On 20/07/2016 3:19 AM, Alan Burlison wrote:
> This removes redundant/incorrect compilation flags from the Solaris
> build environment.
>
> https://bugs.openjdk.java.net/browse/JDK-8161057
> http://cr.openjdk.java.net/~dcubed/for_alanbur/8161057-webrev/0-jdk9-hs-all/
>
>
> I already have one commend from DanD:
>
>> jdk/src/demo/share/jvmti/java_crw_demo/sample.makefile.txt
>>     Copyright year updated to '2015' instead of '2016'.
>
> I've already fixed that in my workspace but it's still present in the
> above webrev.
>
> There were some JPRT test failures on OSX and Windows, as this changeset
> doesn't affect those platforms I believe they can be ignored.

If this is with "-testset hotspot" then it shouldn't happen, in that 
case please drop me an email pointing to the job. For other testsets, 
yes they are transient/intermittent failures.

> There is some related cleanup in deploy, that will be covered by
> https://bugs.openjdk.java.net/browse/JDK-8161081, by removing the
> Solaris-related scripts.

Not an OpenJDK issue so we will handle that internally.

Thanks,
David



More information about the build-dev mailing list