[9] RFR: 8160873: (cs) JDK9 Build failure on Hindi locale
Naoto Sato
naoto.sato at oracle.com
Thu Jul 21 00:48:12 UTC 2016
Thanks for the review Tim!
On 7/20/16 5:40 PM, Tim Bell wrote:
> Naoto:
>
>> Please review the fix to the following issue:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8160873
>>
>> The proposed fix is located at:
>>
>> http://cr.openjdk.java.net/~naoto/8160873/webrev.01/
>>
>> The gist of the issue is that those tools used to generate sources at
>> build time were affected by the default locale, and if they use some
>> number formatting functions, the results end up including locale
>> dependent digits. The fix is to force tools to run in en-US locale by
>> providing user.language/country properties to bootjdk arguments.
>
> Looks good to me.
>
> It is already common practice for the build to set:
>
> LC_ALL=C
> export LC_ALL
That works fine on Solaris/Linux platoforms, but for Windows/Linux,
Java's default locale is determined from the
ControlPanel/SystemPreferences user settings, thus those system
properties need to be set.
Naoto
More information about the build-dev
mailing list