Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

David DeHaven david.dehaven at oracle.com
Wed Jun 8 20:25:58 UTC 2016


Sorry, we had LIVECONNECT_PKGS previously...

-DrD-

> How about NON_CORE_PKGS.gmk for javadoc?
> 
> Something like:
> 
> diff --git a/make/common/NON_CORE_PKGS.gmk b/make/common/NON_CORE_PKGS.gmk
> --- a/make/common/NON_CORE_PKGS.gmk
> +++ b/make/common/NON_CORE_PKGS.gmk
> @@ -44,6 +44,8 @@
>     org.w3c.dom.events \
>     org.w3c.dom.views
> 
> +JSOBJECT_PKGS = netscape.javascript
> +
> JDI_PKGS = com.sun.jdi \
>     com.sun.jdi.event \
>     com.sun.jdi.request \
> @@ -113,6 +115,7 @@
> 
> # non-core packages in rt.jar
> NON_CORE_PKGS = $(DOMAPI_PKGS) \
> +    $(JSOBJECT_PKGS) \
>     $(MGMT_PKGS) \
>     $(JAAS_PKGS) \
>     $(JGSS_PKGS) \
> 
> -DrD-
> 
>> The client team owns jdk.jsobject module and so I add awt-dev to this thread.  And bcc jdk9-dev.
>> 
>> It is not Java SE API and it should not add to CORE-PKGS.gmk.  As for @Deprecated, I believe the plan is to remove the getWindows method in a future release. Kevin and Dave can confirm.
>> 
>> Mandy
>> 
>>> On Jun 8, 2016, at 12:33 PM, Daniil Titov <daniil.x.titov at oracle.com> wrote:
>>> 
>>> Hello,
>>> 
>>> 
>>> 
>>> Please review the fix for JDK 9.
>>> 
>>> 
>>> 
>>> The fix adds @Deprecated annotation to netscape.javascript.JSObject.getWindow(Applet) method and ensures that netscape.javascript package is included in the generated docs.
>>> 
>>> 
>>> 
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8156960
>>> 
>>> 
>>> 
>>> Webrev:   http://cr.openjdk.java.net/~dtitov/8156960/jdk/webrev.00/
>>> 
>>>        http://cr.openjdk.java.net/~dtitov/8156960/webrev.00/
>>> 
>>> 
>>> 
>>> 
>>> 
>>> Best regards,
>>> 
>>> Daniil
>> 
> 




More information about the build-dev mailing list