RFR: JDK-8055735: JDK_FILTER is broken

Claes Redestad claes.redestad at oracle.com
Thu Jun 9 12:18:03 UTC 2016



On 2016-06-09 14:11, Erik Joelsson wrote:
> You have a point, we should avoid relying on uninitialized variables 
> being empty.
>
> http://cr.openjdk.java.net/~erikj/8055735/webrev.top.02/

Thanks, looks good to me!

/Claes

>
> /Erik
>
> On 2016-06-09 13:06, Claes Redestad wrote:
>> Looks OK to me, although I'd somehow be happier if FAIL_NO_SRC was 
>> explicitly set to true when JDK_FILTER isn't set.
>>
>> /Claes
>>
>> On 2016-06-09 12:40, Erik Joelsson wrote:
>>> After the source code restructure, the JDK_FILTER functionality is not
>>> working well. The first module that needs to be recompiled gets the
>>> filter applied, but then the dependents also get it and the macro finds
>>> zero files and fails the build. I have created a fix for this that 
>>> makes
>>> the build pass, but JDK_FILTER is still not functioning very well.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8055735
>>> Webrev: http://cr.openjdk.java.net/~erikj/8055735/webrev.top.01/
>>>
>>> /Erik
>




More information about the build-dev mailing list