RFR: JDK-8055735: JDK_FILTER is broken

Tim Bell tim.bell at oracle.com
Thu Jun 9 14:32:57 UTC 2016


Erik:

On 06/09/16 05:23, Alan Bateman wrote:
>
>
> On 09/06/2016 13:18, Claes Redestad wrote:
>>
>>
>> On 2016-06-09 14:11, Erik Joelsson wrote:
>>> You have a point, we should avoid relying on uninitialized variables 
>>> being empty.
>>>
>>> http://cr.openjdk.java.net/~erikj/8055735/webrev.top.02/
>>
>> Thanks, looks good to me!
>>
> This looks okay to me too.
>
> -Alan.

Looks good to me as well.

make/common/JavaCompilation.gmk - this file looks fine, but I am puzzled 
by the large numbers reported by webrev:

      285 lines changed: 91 ins; 86 del; 108 mod; 292 unchg

Did you do some whitespace cleanup?

Tim




More information about the build-dev mailing list