Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

Kevin Rushforth kevin.rushforth at oracle.com
Thu Jun 9 18:07:35 UTC 2016


Looks fine to me.

-- Kevin


Daniil Titov wrote:
> Thank you, Mandy!
>
> The long line is corrected.
>
> Webrev: http://cr.openjdk.java.net/~dtitov/8156960/jdk/webrev.03
>         http://cr.openjdk.java.net/~dtitov/8156960/webrev.03
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8156960
>
> Best regards,
> Daniil
>
>
>
>
> -----Original Message-----
> From: Mandy Chung 
> Sent: Thursday, June 09, 2016 9:23 AM
> To: Daniil Titov
> Cc: Erik Joelsson; David Dehaven; Stuart Marks; build-dev; build-infa-dev at openjdk.java.net; awt-dev; Kevin Rushforth
> Subject: Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method
>
>
>   
>> On Jun 9, 2016, at 9:08 AM, Daniil Titov <daniil.x.titov at oracle.com> wrote:
>>
>> Thank you, Erik!
>>
>> Please review the new version of the patch that has "../" fixed:
>>
>> Webrev: http://cr.openjdk.java.net/~dtitov/8156960/jdk/webrev.02
>>        http://cr.openjdk.java.net/~dtitov/8156960/webrev.02/
>>
>>     
>
> Looks okay.  Nit: in JSObject.java - line 154 long line to be wrapped. 
>
> Mandy
>   



More information about the build-dev mailing list