JDK debug builds on OSX copying dSYM
Radosław Smogura
mail at smogura.eu
Wed Jun 22 13:43:54 UTC 2016
Hi Erik,
Thank you for checking this. I’m a bit confused about NativeCompilation.gmk. Originally, first patch was related to basics.m4 in common tree
- # Always force rm.
- RM="$RM -f"
+ # Always force rm and make it recursive
+ RM="$RM -rf”
In any way, today I have rechecked things again on JDK9, but without above change (I’ve left only parenthesis fix) and I haven't reproduced error that dSYM could not be removed as it is folder.
Best regards,
Radek
> On 22 Jun 2016, at 03:18, Erik Joelsson <erik.joelsson at oracle.com> wrote:
>
> The parentheses is definitely a bug, but I don't see why we need recursive delete by default. In what situation is the *.dSYM dir not being deleted?
>
> I did notice that things got weird in NativeCompilation.gmk which I fixed like this:
>
> diff -r 1db1ada70b16 make/common/NativeCompilation.gmk
> --- a/make/common/NativeCompilation.gmk
> +++ b/make/common/NativeCompilation.gmk
> @@ -833,7 +833,8 @@
> # The dependency on TARGET is needed on windows for debuginfo files
> # to be rebuilt properly.
> $$($1_OUTPUT_DIR)/% : $$($1_OBJECT_DIR)/% $$($1_TARGET)
> - # Use cp -r since on macosx, the dSYM is a directory
> + # Use -r since on macosx, the dSYM is a directory
> + $(RM) -r $$@
> $(CP) -r $$< $$@
> endif
>
> /Erik
>
> On 2016-06-21 14:33, Radosław Smogura wrote:
>> Hi Vladimir,
>>
>> I’m so sorry, I haven’t checked for such list and thank you for forwarding :)
>>
>> Bets regards,
>> Radek
>>> On 21 Jun 2016, at 22:31, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>>>
>>> Thank you, Radek
>>>
>>> This should be reviewed in 'build' mailing list.
>>>
>>> Thanks,
>>> Vladimir
>>>
>>> -------- Forwarded Message --------
>>> Subject: JDK debug builds on OSX copying dSYM
>>> Date: Mon, 20 Jun 2016 21:01:48 +0000
>>> From: Radosław Smogura <mail at rsmogura.net>
>>> To: hotspot-compiler-dev at openjdk.java.net <hotspot-compiler-dev at openjdk.java.net>
>>>
>>> Hello,
>>>
>>> Recently I tried to compile JDK9 on OS X, I've found two issues related to installing debug symbols, which on OSX are package-folders.
>>>
>>> 1. Install-file macro doesn't remove dSYM folder, as used rm -f, instead of rm -rf
>>> 2. There was additional parenthesis in Dist.gmk which caused dSYM not to be copied.
>>>
>>> The overview of changes is attached.
>>>
>>> Kind regards,
>>> Radek Smogura
>>>
>>> <jdk9-root-make-dsym-remove.diff><jdk9-hotspot-osx-copy-dsym.diff>
>
More information about the build-dev
mailing list