RFR: 8081676 Verify that configure detects AS on Solaris and print help otherwise

Erik Joelsson erik.joelsson at oracle.com
Mon Jun 27 09:46:20 UTC 2016



On 2016-06-27 01:40, David Holmes wrote:
> Hi Tim,
>
> On 25/06/2016 10:52 AM, Tim Bell wrote:
>> Hello
>>
>> Please review this added sanity check for the Solaris assembler (as).
>>
>> 'as' is not installed by default on Solaris, and it would be better to
>> fail fast if missing.
>
Looks good to me too.
> Fix looks good. Makes me wonder what else may be missing by default - 
> eg GNU make ?
>
At least GNU make we check for. This change was prompted by someone 
trying to a build on a very barebone Solaris install. Hopefully that 
experiment found all the potentially missing things.

/Erik
> Thanks,
> David
>
>> Bug report:
>>   https://bugs.openjdk.java.net/browse/JDK-8081676
>>
>> Webrev:
>>   http://cr.openjdk.java.net/~tbell/8081676/
>>
>> Note: This is a change to toolchain.m4.  I did not include the
>> generated-configure.sh files in the webrev, but I will regenerate and
>> push them as well.
>>
>> Thank you in advance-
>>
>> Tim
>>




More information about the build-dev mailing list