RFR(S): 8160423: Serial build is broken because of missing dependencies for jmod

Volker Simonis volker.simonis at gmail.com
Tue Jun 28 07:15:23 UTC 2016


Hi,

can somebody please review the following change:

http://cr.openjdk.java.net/~simonis/webrevs/2016/8160423/
https://bugs.openjdk.java.net/browse/JDK-8160423

The serial build (i.e. JOBS=1) is currently not working because of
missing dependencies for jmod. At the time when jmod is called during
the build, various files like jvm.cfg and tzdb.dat which are required
for the proper working of jmod, are not in place.

The fix is easy, just add the corresponding dependencies to JMOD_TARGETS.

I'd strongly suggest to add a serial build to at least one of your
test builds to keep the build sane. Otherwise the dependencies can
easily be broken without somebody noticing it because apparently
nowadays nobody is ever building with JOBS=1 any more :)

Thank you and best regards,
Volker

PS: a quick check showed no performance degradation after this fix for
the parallel build with JOBS=4



More information about the build-dev mailing list