RFR(S): 8160423: Serial build is broken because of missing dependencies for jmod

[Volker Simonis]

Hi Erik,

thanks for the quick review. I've just pushed the fix to jdk9-dev.

Regarding the serial build: this could run as a test once a week or so
as part of integration testing for example. But that's of course up to
you.

Needless to say that a working sequential build is an absolute
requirement for finding any other build bug :)

Regards,
Volker


On Tue, Jun 28, 2016 at 9:27 AM, Erik Joelsson <erik.joelsson at oracle.com> wrote:
>
>
> On 2016-06-28 09:15, Volker Simonis wrote:
>>
>> Hi,
>>
>> can somebody please review the following change:
>>
>> http://cr.openjdk.java.net/~simonis/webrevs/2016/8160423/
>> https://bugs.openjdk.java.net/browse/JDK-8160423
>>
>> The serial build (i.e. JOBS=1) is currently not working because of
>> missing dependencies for jmod. At the time when jmod is called during
>> the build, various files like jvm.cfg and tzdb.dat which are required
>> for the proper working of jmod, are not in place.
>>
>> The fix is easy, just add the corresponding dependencies to JMOD_TARGETS.
>
> Good catch! I'm disappointed in myself for missing this. Looks good!
>>
>> I'd strongly suggest to add a serial build to at least one of your
>> test builds to keep the build sane. Otherwise the dependencies can
>> easily be broken without somebody noticing it because apparently
>> nowadays nobody is ever building with JOBS=1 any more :)
>
> We currently don't have a good place to do that and I'm not sure it's really
> worth it. A complete serial build is very slow so it would need to run at a
> time and place where we don't need to wait for it. Most of the time, missing
> dependencies show up often enough in parallel builds in my experience.
>>
>> Thank you and best regards,
>> Volker
>>
>> PS: a quick check showed no performance degradation after this fix for
>> the parallel build with JOBS=4
>
> This change does not look like it would, but thanks for checking.
>
> /Erik