[9-dev] RfR: JDK-8132743: Move netscape.javascript package from jdk.plugin to new module

Mandy Chung mandy.chung at oracle.com
Thu Mar 3 19:59:32 UTC 2016


> On Mar 3, 2016, at 7:52 AM, David DeHaven <david.dehaven at oracle.com> wrote:
> 
> 
> JBS Issue:
> https://bugs.openjdk.java.net/browse/JDK-8132743
> 
> Code review:
> http://cr.openjdk.java.net/~ddehaven/8132743/webrev.0/

Looks okay.  There is no @since - I guess it’s okay because netscape.javascript has been shipped with plugin for long time.

package-info.java
    "when running in an {@link java.applet.Applet Applet}” - is this true when running with JavaFX webkit?

JSObject.java
   @throws JSException is missing in the methods

   Does it throw NPE if the parameter is null?  Or JSException - that needs to be specified.

   Nit: it’d be good to wrap null with {@code null} in the javadoc. 

Mandy




More information about the build-dev mailing list