RFR: JDK-8151297: Class name change for CLDRLocaleDataMetaInfo_jdk_localedata needs updating in makefile

Mandy Chung mandy.chung at oracle.com
Fri Mar 4 17:13:50 UTC 2016


> On Mar 4, 2016, at 7:45 AM, Erik Joelsson <erik.joelsson at oracle.com> wrote:
> 
> When the generated class sun.util.resources.cldr.provider.CLDRLocaleDataMetaInfo_jdk_localedata changed names to sun.util.resources.cldr.provider.CLDRLocaleDataMetaInfo in JDK-8150434, the make target reference in GensrcCLDR.gmk was forgotten. The consequence of this is that the gensrc step is rerun at every build, causing the jdk.localedata module to also be compiled at every build.
> 
> I have verified that with the below patch, a rebuild does nothing again.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8151297
> Patch:
> diff -r d52c28899f24 make/gensrc/GensrcCLDR.gmk
> --- a/make/gensrc/GensrcCLDR.gmk
> +++ b/make/gensrc/GensrcCLDR.gmk
> @@ -30,7 +30,7 @@
>  GENSRC_DIR := $(SUPPORT_OUTPUTDIR)/gensrc/jdk.localedata
>  
>  CLDR_BASEMETAINFO_FILE := $(GENSRC_BASEDIR)/sun/util/cldr/CLDRBaseLocaleDataMetaInfo.java
> -CLDR_METAINFO_FILE := $(GENSRC_DIR)/sun/util/resources/cldr/provider/CLDRLocaleDataMetaInfo_jdk_localedata.java
> +CLDR_METAINFO_FILE := $(GENSRC_DIR)/sun/util/resources/cldr/provider/CLDRLocaleDataMetaInfo.java
>  
>  CLDR_BASE_LOCALES := "en-US”

+1

Thanks for catching it.  
Mandy




More information about the build-dev mailing list