RFR: JDK-8151302: Attempt at silencing build log broke html32.bdtd
Mandy Chung
mandy.chung at oracle.com
Fri Mar 4 17:18:05 UTC 2016
> On Mar 4, 2016, at 8:03 AM, Erik Joelsson <erik.joelsson at oracle.com> wrote:
>
> InJDK-8146403 <https://bugs.openjdk.java.net/browse/JDK-8146403>, I accidentally added a $(LOG_INFO) to the DTDBuilder command. The problem is that this command prints its generated output to stdout, which we pipe to a file. The LOG_INFO macro instead redirects this to /dev/null unless a high enough log level is active. Luckily, in JPRT and RE builds, we run with LOG=debug so the generation works, but for normal developer builds, it's currently broken.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8151302
> Patch:
> diff -r d52c28899f24 make/gendata/GendataHtml32dtd.gmk
> --- a/make/gendata/GendataHtml32dtd.gmk
> +++ b/make/gendata/GendataHtml32dtd.gmk
> @@ -30,6 +30,6 @@
> $(call LogInfo, Generating HTML DTD file)
> $(MKDIR) -p $(@D)
> $(RM) $@
> - ($(TOOL_DTDBUILDER) $(LOG_INFO) html32 > $@) || exit 1
> + ($(TOOL_DTDBUILDER) html32 > $@) || exit 1
>
> TARGETS += $(HTML32DTD)
+1
Mnady
More information about the build-dev
mailing list