RFR: JDK-8151656: Minor tweaks to old Hotspot build to ease comparison with new

Christian Thalinger christian.thalinger at oracle.com
Tue Mar 15 21:02:20 UTC 2016


> On Mar 15, 2016, at 12:06 AM, Erik Joelsson <erik.joelsson at oracle.com> wrote:
> 
> Any chance I could get a second review on this? Preferably from the hotspot team.

It’s not quite obvious to me what the __FILE__ change is.  Maybe an example would help.

> 
> /Erik
> 
> On 2016-03-11 18:16, Erik Joelsson wrote:
>> In preparation for the new Hotspot build, there are a few changes to the old build that needs to happen first. These changes should be harmless, but do impact the generated binaries some. These changes are:
>> 
>> * Standardizing sort order for objects on link command line on Windows to a locale independent order.
>> * Working around compare differences caused by the __FILE__ macro in certain generated files by overriding the value of __FILE__ in those files.
>> 
>> By making these changes first and separate from introducing the new build we reduce the potential impact of when we do introduce the new build.
>> 
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8151656
>> Webrev: http://cr.openjdk.java.net/~erikj/8151656/index.html
>> 
>> /Erik
> 




More information about the build-dev mailing list