RFR(XS): 8151987: jexec should be executable

Volker Simonis volker.simonis at gmail.com
Wed Mar 16 12:19:11 UTC 2016


On Wed, Mar 16, 2016 at 12:29 PM, Volker Simonis <volker.simonis at gmail.com>
wrote:

>
>
> On Wed, Mar 16, 2016 at 12:14 PM, Alan Bateman <Alan.Bateman at oracle.com>
> wrote:
>
>> On 16/03/2016 11:08, Volker Simonis wrote:
>>
>>> Hi,
>>>
>>> can I please have a review for the following small fix:
>>>
>>> http://cr.openjdk.java.net/~simonis/webrevs/2016/8151987/
>>> https://bugs.openjdk.java.net/browse/JDK-8151987
>>>
>>> 'jexec' is currently not executable in the created images (i.e.
>>> images/{jdk,jre}/lib/jexec.
>>>
>>> There is currently a special handling in ImageBuilder for
>>> 'jspawnhelper' which apparently had the same problem.
>>>
>>> Volker - this patches the temporary image builder that we have in JDK 9.
>> This will be go away, to be replaced by jlink, when we bring the module
>> system into JDK 9. This will hopefully be next week.
>>
>>
> OK, but then we will have to fix jlink. I've just verified that a 'jake'
> build from last week has the same problem:
>
> la ../output-jake-opt/images/jdk/lib/jexec
> -rw-r--r-- 1 d000000 kmem 22034 Mar  7 15:02
> ../output-jake-opt/images/jdk/lib/jexec
>
>
>
So here comes a new (and even smaller) version of the patch which fixes
jlink in the same way:

http://cr.openjdk.java.net/~simonis/webrevs/2016/8151987.v1/

Please feel free to push it to jake or I can push it to jdk9-dev once jake
is there.

Regards,
Volker


<http://cr.openjdk.java.net/%7Esimonis/webrevs/2016/8151987.v1>

>
>
-Alan.
>>
>
>



More information about the build-dev mailing list