RFR(xs): 8155821: Typo for s390x for HOTSPOT_$1_CPU_DEFINE

Severin Gehwolf sgehwolf at redhat.com
Mon May 2 12:23:45 UTC 2016


On Fri, 2016-04-29 at 14:51 +0200, Matthias Klose wrote:
> The build 116 broke the zero build on s390x, this is just a simple typo.  Please 
> apply. This at least lets the first build finish in the bootcycle build before 
> the vm crashes in the second one.
> 
> However this build change broke the build on all archs which are not explicitly 
> handled in this alternative, because hotspot/makefiles/lib/CompileJvm.gmk uses 
> -D$(HOTSPOT_TARGET_CPU_DEFINE) in JVM_CFLAGS_TARGET_DEFINES

I've created a bug and uploaded a webrev. Could somebody please review
and sponsor this?

Bug: https://bugs.openjdk.java.net/browse/JDK-8155821
webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8155821/webrev.01/
HG-exported changeset: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8155821/JDK-8155821.jdk9.top.export.patch

Thanks,
Severin

> So at least the various ARM32 and MIPS* builds need updates.
> 
> Matthias




More information about the build-dev mailing list