RFR: 8156756: Enable build-time use of resource ordering plugin

[Claes Redestad]

On 2016-05-11 18:25, Erik Joelsson wrote:
> Alan is correct , I have issues with the long line. :)
>
> I recommend something like this:
>
> JLINK_ORDER_RESOURCES := \
>     *module-info.class* \
>     @$(SUPPORT_OUTPUTDIR)/classlist/classlist,/java.base/java/* \
>     /java.base/jdk/* \
>     /java.base/sun/* \
>     /java.base/com/* \
>     /jdk.localedata/* \
>     #
>
> JLINK_TOOL := $(JLINK) --modulepath $(IMAGES_OUTPUTDIR)/jmods \
>                --endian $(OPENJDK_BUILD_CPU_ENDIAN) \
>                --order-resources=$(call CommaList, 
> $(JLINK_ORDER_RESOURCE)) \
>                --release-info $(BASE_RELEASE_FILE)

Ok!

http://cr.openjdk.java.net/~redestad/8156756/webrev.01/

Thanks!

/Claes

>
> /Erik
>
> On 2016-05-11 18:05, Alan Bateman wrote:
>> On 11/05/2016 16:56, Claes Redestad wrote:
>>> Hi,
>>>
>>> please review this change to enable the --order-resources plugin 
>>> during build, which helps cold start scenarios by improving locality
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8156756
>>> Webrev: http://cr.openjdk.java.net/~redestad/8156756/webrev.01/
>>>
>>> Ordering by classlist alone gives a good boost and could have been a 
>>> sufficient improvement, while grouping different parts of java.base 
>>> (while allowing others, like javax) to order later in the image 
>>> seems marginally profitable as well.
>> Content wide then this looks okay, I'm not sure about the very long 
>> line. Erik might advise on this.
>>
>> -Alan
>