Configure(still?) broken on OS X

[Scott Palmer]

It looks like the fix from JDK-8147754 is present, but a straight
./configure is still failing for me.

$ hg path
default = http://hg.openjdk.java.net/jdk9/jdk9

$hg sum
parent: 2054:e68942b0ba37 tip

$ hg grep opt/X11
common/autoconf/generated-configure.sh:2053:              # Due to changes
in OSX 10.11 XQuartz now installs to /opt/X11
common/autoconf/generated-configure.sh:2053:
 FREETYPE_BASE_DIR="$SYSROOT/opt/X11"
common/autoconf/lib-freetype.m4:1924:              # Due to changes in OSX
10.11 XQuartz now installs to /opt/X11
common/autoconf/lib-freetype.m4:1924:
 FREETYPE_BASE_DIR="$SYSROOT/opt/X11"
...

I was just setting this up on a different Mac and ./configure chugs aways
and fails like this:
...
checking for cups/cups.h... yes
checking cups/ppd.h usability... yes
checking cups/ppd.h presence... yes
checking for cups/ppd.h... yes
configure: error: Could not find freetype!
/Users/scott/dev/jdk9/common/autoconf/generated-configure.sh: line 82: 5:
Bad file descriptor
configure exiting with result code 1

Again adding  --with-freetype=/opt/X11 when running ./configure fixes the
issue.

Scott

On Mon, Jan 25, 2016 at 10:20 AM, David DeHaven <david.dehaven at oracle.com>
wrote:

>
> >>>> This came up a while back, probably on another list...
> >>>>
> >>>> XQuartz had to change the install location due to 10.11 not allowing
> installation to /usr/X11, so our configure script should be updated to also
> check in /opt/X11 now. I don't know if a bug was ever filed for this or not.
> >>>>
> >>>> To answer the earlier question: Yes, freetype is required for OpenJDK
> builds on Mac.
> >>> Incidentally, I have the same version of XQuartz installed on 10.10.5
> and it creates symlinks:
> >>> /usr/X11 -> /opt/X11
> >>> /usr/X11R6 -> /opt/X11
> >>>
> >>> but those symlinks cannot be created on 10.11 for the aforementioned
> reason.
> >>>
> >>> -DrD-
> >>>
> >> I filed an issue to fix this and provided a proposed fix, but I've not
> tested it at all (and I can't at the moment...)
> >> https://bugs.openjdk.java.net/browse/JDK-8147754
> >
> > I think we can be reasonably sure that if --with-freetype=/opt/X11
> works, then your fix is working.
> >
> > I think your fix looks okay (apart from indentation but that might be
> Jira messing), but for formalitys sake I'd like you to send out a formal
> RFR. You don't need to create a webrev, the patch inline is ok.
>
> Yeah, that's JIRA messing up the indentation. I've not found a way to use
> preformatted blocks in JIRA comments yet.
>
> I'll post an official RFR later this morning.
>
> -DrD-
>
>