RFR: JDK-8157574: Mac fastdebug bundles have wrong directory layout

Mandy Chung mandy.chung at oracle.com
Mon May 23 15:07:01 UTC 2016


Looks okay to me.

Mandy

> On May 23, 2016, at 7:00 AM, Erik Joelsson <erik.joelsson at oracle.com> wrote:
> 
> Hello,
> 
> In JDK-8136777 I introduced the new bundle targets which creates .tar.gz bundles of all the images. The naming and layout of these bundles were based on how Oracle has created such bundles internally before. Except in one case, where I missed: Macosx debug.
> 
> As I see it, there is no real right or wrong here, just opinion and history. On Macosx, for release builds, the image layout is a bit different compared to other platforms:
> 
> jdk-9.jdk/Contents/Home/
> 
> compared to:
> 
> jdk-9/
> 
> On all other platforms, the debug bundles look like this:
> 
> jdk-9/$(DEBUG_LEVEL)/
> 
> Which makes it possible to overlay both release and debug bundles in the same directory.
> 
> Now the question is what the layout in a debug bundle for macosx should look like. JDK-8136777 resulted in the same as for macosx release:
> 
> jdk-9.jdk/Contents/Home/
> 
> While Oracle historically used the same as other platforms:
> 
> jdk-9/$(DEBUG_LEVEL)/
> 
> This change aligns with Oracle's old way so as to reduce friction and adoption internally.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8157574
> Webrev: http://cr.openjdk.java.net/~erikj/8157574/webrev.top.01/
> 
> /Erik




More information about the build-dev mailing list