RFR: JDK-8168982: Missing dependency for docs-copy

[Tim Bell]

Erik:

Looks good.

Tim

> Magnus is correct. When rewriting the docs build in JDK-8168772, a
> dependency was missed on the top level. The docs-copy target needs
> jdk.jdi-gensrc as a prerequisite since that target generates
> support/javadoc/platform/jpda/jdwp/jdwp-protocol.html, which is used by
> docs-copy.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8168982
>
> Patch:
>
> diff -r a327b728bbe7 make/Main.gmk
> --- a/make/Main.gmk
> +++ b/make/Main.gmk
> @@ -683,7 +683,8 @@
>
>    docs-javadoc: $(GENSRC_TARGETS) rmic
>
> -  docs-copy: hotspot
> +  # The gensrc step for jdk.jdi creates an html file that is used by
> docs-copy.
> +  docs-copy: hotspot jdk.jdi-gensrc
>
>    docs-zip: docs-javadoc docs-copy
>
> Verified by doing:
>
> $ make clean
> $ make docs-copy
>
> /Erik
>
> On 2016-11-01 00:27, Lance Andersen wrote:
>> In case this bites anyone else, the workaround below will keep you
>> going :-)
>>
>> Thank you again Magnus
>>
>> Best
>> Lance
>>> On Oct 31, 2016, at 2:09 PM, Magnus Ihse Bursie
>>> <magnus.ihse.bursie at oracle.com> wrote:
>>>
>>> Lance,
>>>
>>> This is most likely due to a missed dependency in the recent Javadoc
>>> refactoring, which is triggered on your build platform.
>>>
>>> A workaround for you right now is to do 'make jdk.jdi' first, which
>>> will make sure the Javadoc stage later will succeed.
>>>
>>> Sorry for the inconvenience. :-(
>>>
>>> /Magnus
>>>
>>>> 31 okt. 2016 kl. 19:07 skrev Lance Andersen
>>>> <lance.andersen at oracle.com>:
>>>>
>>>> Hi,
>>>>
>>>> I just pulled the latest JDK 9 source (open and closed) and can no
>>>> longer build as I am getting the following error:
>>>>
>>>> make[3]: *** No rule to make target
>>>> `/Users/ljanders/Documents/hg-workspaces/openjdk9/modular-dev/build/macosx-x86_64-normal-server-release/support/gensrc/jdk.jdi/jdwp-protocol.html',
>>>> needed by
>>>> `/Users/ljanders/Documents/hg-workspaces/openjdk9/modular-dev/build/macosx-x86_64-normal-server-release/support/javadoc/platform/jpda/jdwp/jdwp-protocol.html'.
>>>> Stop.
>>>> make[2]: *** [docs-copy] Error 2
>>>>
>>>>
>>>>
>>>> I did a  make clean prior to make all.
>>>>
>>>> Anyone else encounter this?
>>>>
>>>>
>>>> Thank you in advance…
>>>>
>>>> Best
>>>> Lance
>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance
>>>> Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>>> Oracle Java Engineering
>>>> 1 Network Drive
>>>> Burlington, MA 01803
>>>> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>>>>
>>>>
>>>>
>>   <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>   <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>>   <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance
>> Andersen| Principal Member of Technical Staff | +1.781.442.2037
>> Oracle Java Engineering
>> 1 Network Drive
>> Burlington, MA 01803
>> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>>
>>
>>
>