RFR: JDK-8066474: Remove the lib/$ARCH directory from Linux and Solaris images

[Lindenmaier, Goetz]

Hi,

linuxx86_64 has the same issue.  I tested it with the jdk9/hs repo:

jdk/src/java.base/unix/native/libjli/ergo_i586.c: In function ServerClassMachineImpl:
jdk/src/java.base/unix/native/libjli/ergo_i586.c:196:30: error: expected ) before LIBARCHNAME

Best regards,
  Goetz

> -----Original Message-----
> From: Lindenmaier, Goetz
> Sent: Montag, 21. November 2016 12:35
> To: 'Vladimir Kozlov' <vladimir.kozlov at oracle.com>; Erik Joelsson
> <erik.joelsson at oracle.com>; build-dev <build-dev at openjdk.java.net>;
> core-libs-dev <core-libs-dev at openjdk.java.net>; hotspot-dev developers
> <hotspot-dev at openjdk.java.net>
> Subject: RE: RFR: JDK-8066474: Remove the lib/$ARCH directory from Linux
> and Solaris images
> 
> Hi,
> 
> we appreciate this change a lot, and also if /server would go away.
> 
> I built and tested it on linuxppcle, aixppc and linuxs390.
> 
> There is still a place that refers to a removed variables
> and breaks the build:
> jdk/src/java.base/unix/native/libjli/ergo.c:94  LIBARCHNAME
> You can probably just replace LIBARCHNAME by ARCH which is set to
> the same value.
> 
> I would propose to remove VM_CPU from hotspot/test/test_env.sh after
> you
> removed the last place where it is used.  (VM_BITS is dead, too.)
> 
> Best regards,
>   Goetz.
> 
> > -----Original Message-----
> > From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On
> > Behalf Of Vladimir Kozlov
> > Sent: Freitag, 18. November 2016 17:41
> > To: Erik Joelsson <erik.joelsson at oracle.com>; build-dev <build-
> > dev at openjdk.java.net>; core-libs-dev <core-libs-dev at openjdk.java.net>;
> > hotspot-dev developers <hotspot-dev at openjdk.java.net>
> > Subject: Re: RFR: JDK-8066474: Remove the lib/$ARCH directory from Linux
> > and Solaris images
> >
> > Finally! :)
> >
> > Hotspot changes looks fine to me. But you missed
> > hotspot/make/hotspot.script file.
> >
> > Our colleges in RH and SAP should test these changes on their platforms.
> >
> > Next step would be removal of client/server sub-directories on platforms
> > where we have only Server JVM (64-bit JDK has only Server JVM).
> >
> > Thanks,
> > Vladimir
> >
> > On 11/18/16 7:30 AM, Erik Joelsson wrote:
> > > Hello,
> > >
> > > Please review this change which removes the $ARCH sub directory in the
> > > lib directory of the runtime images, which is an outstanding issue from
> > > the new runtime images. Most of the changes are in the build, but there
> > > are some in hotspot and launcher source. I have verified -testset
> > > hotspot and default in JPRT as well as tried to run as many jtreg tests
> > > as possible locally. I could only really find two tests that needed to
> > > be adjusted.
> > >
> > > Bug: https://bugs.openjdk.java.net/browse/JDK-8066474
> > >
> > > Webrev: http://cr.openjdk.java.net/~erikj/8066474/webrev.01
> > >
> > > /Erik
> > >