RFR: JDK-8168037 using ZIP as a make variable conflicts with zip's use of ZIP as an environment variable

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Tue Nov 22 11:19:19 UTC 2016


On 2016-11-22 11:23, Erik Joelsson wrote:
> Hello,
>
> In spec.gmk.in, shouldn't it be "ZIPEXE:=@ZIPEXE@"?

You are absolutely right.

How could that ever have worked?! And I did run it through jprt...

I'll fix and re-check.

/Magnus

>
> /Erik
>
>
> On 2016-11-22 10:58, Magnus Ihse Bursie wrote:
>> Following the standard by other tools, we set ZIP to the path of the 
>> zip binary.
>>
>> However, ZIP is interpreted as a way to control options for the 
>> Info-Zip zip binary.
>>
>> The solution is to rename the variable ZIP to ZIPEXE.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8168037
>> WebRev: 
>> http://cr.openjdk.java.net/~ihse/JDK-8168037-rename-ZIP-to-ZIPEXE/webrev.01
>>
>> /Magnus
>>
>




More information about the build-dev mailing list