RFR: JDK-8031567 Better model for storing source revision information

[Erik Joelsson]

On 2016-11-25 00:27, David Holmes wrote:
> Hi Magnus,
>
> On 25/11/2016 12:54 AM, Magnus Ihse Bursie wrote:
>> We are currently using "hg tip" to create the "source_tips" file, and
>> correspondingly for the closed bundles.
>>
>> But this is incorrect. It will show the latest committed version in the
>> repo, not the actual workspace (i.e. the version we actually build).
>>
>> For this, we should use "hg id" instead. If we have a clean workspace
>> updated to the tip, it will produce the same output. Otherwise it will
>> show what we build, with a traliing "+" if there are local,
>> non-committed changed.
>
> So hg id doesn't actually help in someone else recreating the same 
> sources as a build, because they won't have access to the uncommitted 
> changes. This is simply an indicator that this build has such 
> uncommitted changes. Is that right?
>
That is correct, but at least you will know that there were uncommitted 
changes.

/Erik
> Thanks,
> David
>
>
>> Also, we should not name the file "tip" in this case.
>>
>> And finally, we do not need to sprinkle these files all around in all
>> repos. The entire handling should be more clearly abstracted.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8031567
>> WebRev:
>> http://cr.openjdk.java.net/~ihse/JDK-8031567-clean-up-source-revision-stamps/webrev.01 
>>
>>
>>
>> /Magnus