RFR: JDK-8170284: Move fine granular hotspot make targets to top level

[Erik Joelsson]

On 2016-11-25 00:30, David Holmes wrote:
> On 24/11/2016 8:12 PM, Erik Joelsson wrote:
>> On 2016-11-24 00:54, David Holmes wrote:
>>> Hi Erik,
>>>
>>> On 24/11/2016 2:28 AM, Erik Joelsson wrote:
>>>> Discovered an issue with cross compiling configurations. In
>>>> buildjdk-spec.gmk.in, need to also override the new variable
>>>> JVM_VARIANTS_MAIN. New webrev:
>>>>
>>>> http://cr.openjdk.java.net/~erikj/8170284/webrev.02/
>>>
>>> Seems reasonable but I don't understand these two targets:
>>>
>>> +         $(info $(_) make hotspot-<variant> # Build just the
>>> specified jvm variant)
>>> +         $(info $(_) make hotspot-libs      # Build the native
>>> libraries for hotspot)
>>>
>>> Given that the JVM variant defines which libjvm to build, and that is
>>> the primary "hotspot native library", I don't see how these two can be
>>> distinct ??
>>>
>> In the current build, "hotspot-libs" happens to be synonymous with just
>> "hotspot" as it builds all the native libraries, and the hotspot build
>> doesn't have any more targets in its pipeline. In theory, we could add
>> additional build phases for hotspot in the future. I agree it's not very
>> useful to document this target as it currently stands however.
>
> So you got rid of the help doc but still kept the target ??
>
Yes, I think it makes sense to complete the pattern of 
hotspot-gensrc/hotspot-libs, 
hotspot-<variant>-gensrc/hotspot-<variant>-libs, but since it doesn't 
serve much of a practical purpose at this point, there is no need to 
encourage users to use it in the help text.

/Erik
> David
>
>> /Erik
>>> Thanks,
>>> David
>>>
>>>> /Erik
>>>>
>>>> On 2016-11-23 16:05, Erik Joelsson wrote:
>>>>> After the hotspot makefile rewrite and the elimination of the hotspot
>>>>> dist output directory, it's now time to create more fine granular top
>>>>> level make targets for building hotspot. This will enable better
>>>>> granularity in between hotspot build steps and the rest of the build.
>>>>> Building native libraries in the JDK will only need to wait for one
>>>>> libjvm to be built. Building docs will only require the gensrc 
>>>>> step in
>>>>> hotspot to be built.
>>>>>
>>>>> Here is the full list of new targets proposed:
>>>>> hotspot-gensrc
>>>>> hotspot-libs
>>>>> hotspot-<variant>
>>>>> hotspot-<variant>-gensrc
>>>>> hotspot-<variant>-libs
>>>>> hotspot-jsig
>>>>>
>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8170284
>>>>>
>>>>> Webrev: http://cr.openjdk.java.net/~erikj/8170284/webrev.01
>>>>>
>>>>> /Erik
>>>>>
>>>>
>>