RFR: JDK-8167488: Race condition in build with new exploded-image-optimize target
Magnus Ihse Bursie
magnus.ihse.bursie at oracle.com
Wed Oct 12 09:20:19 UTC 2016
On 2016-10-11 15:37, Tim Bell wrote:
> Hello Erik:
>
>> When introducing the exploded-image-optimize target, I tried to fix all
>> the dependencies so that the module-info.class files would not be used
>> by any other target at the same time as the optimization was happening.
>> It seems I forgot about one class of such uses. Any java compilation
>> target that links to the classes in jdk/modules is potentially affected.
>>
>> This patch addresses all the cases I could find.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8167488
>>
>> Webrev: http://cr.openjdk.java.net/~erikj/8167488/webrev.01/
>
> Looks good to me.
Looks good to me, too.
Long term, I'd like to see us refactoring the overall build structure
and dependencies. With the build-jdk and the new dependencies created by
Jigsaw, it's beginning to be really tough to figure out how things fit
together.
/Magnus
More information about the build-dev
mailing list