RFR: 8167600 jib make run-test for langtools and intermittent failures on windows-x86

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Wed Oct 19 13:00:43 UTC 2016


On 2016-10-18 06:44, Tim Bell wrote:
> Magnus:
>
> Thank you for the feedback.  See below:
>
>
>> On 2016-10-15 03:23, Tim Bell wrote:
>>> Please review this rework of the langtools/test/Makefile fix done in
>>> 8166648. [1]  ARCH_DATA_MODEL is not set in all test scenarios, so a
>>> better approach is to check the VM about to be tested.
>>>
>>> Bug report:
>>>     https://bugs.openjdk.java.net/browse/JDK-8167600
>>>
>>> Webrev:
>>>     http://cr.openjdk.java.net/~tbell/8167600/webrev.00/
>>>
>>> Testing:
>>>    Successful JPRT runs on all platforms.  Inspected the
>>> <platform>_<arch>.product-c2-langtools_jtreg.log files to verify the
>>> expected flag was used only on 32-bit VMs.
>>
>> Hi Tim,
>>
>> Seems a bit complicated to create a temporary javascript and execute it.
>> Why not try something like:
>> DATA_MODEL=`${JT_JAVA}/bin/java -XshowSettings:properties -version 2>&1
>> | grep sun.arch.data.model | awk '{print $3}'`
>> ?
>
> Excellent idea.  This is much simpler.
>
> Here is an updated webrev.  Tested as before, by submitting a JPRT job 
> and inspecting the .log files.
>
>   http://cr.openjdk.java.net/~tbell/8167600/webrev.01/
Looks good to me.

/Magnus

>
>
> Tim
>
>
>>> Thanks in advance-
>>>
>>> Tim
>>>
>>> [1] JDK-8166648 https://bugs.openjdk.java.net/browse/JDK-8166648
>>
>




More information about the build-dev mailing list