RFR(XS): 8168302: --disable-warnings-as-errors doesn't work for the hotspot build on Solaris

Tim Bell tim.bell at oracle.com
Fri Oct 21 15:36:21 UTC 2016


Hello Volker:

> PING - can somebody please have a look at this trivial change?


The change looks good.  I will sponsor it today.

Tim

> Thanks,
> Volker
>
>
> On Wed, Oct 19, 2016 at 5:54 PM, Volker Simonis
> <volker.simonis at gmail.com> wrote:
>> Hi,
>>
>> can I please get a review and a sponsor for the following trivial change:
>>
>> http://cr.openjdk.java.net/~simonis/webrevs/2016/8168302/
>> https://bugs.openjdk.java.net/browse/JDK-8168302
>>
>> After change "8152666: The new Hotspot Build System" setting
>> --disable-warnings-as-errors doesn't work for the hotspot build on
>> Solaris anymore because JVM_CFLAGS unconditionally contains the option
>> "-xwe" which is equivalent to "-errwarn=%all".
>>
>> Using "-xwe" shouldn't be used because -enable-warnings-as-errors
>> already sets "-errwarn=%all".
>>
>> Thank you and best regards,
>> Volker




More information about the build-dev mailing list