RFR: JDK-8168950: Incremental build of images always rebuilds jmods

Erik Joelsson erik.joelsson at oracle.com
Mon Oct 31 14:37:41 UTC 2016


A mistake in JDK-8166948 is causing jmods and images to always be 
rebuilt on subsequent calls to make when nothing should have changed. I 
forgot to touch the marker file at the end of the recipe for doing the 
module-info optimization.

Bug: https://bugs.openjdk.java.net/browse/JDK-8168950

Patch:

diff -r b913840943c0 make/ExplodedImageOptimize.gmk
--- a/make/ExplodedImageOptimize.gmk
+++ b/make/ExplodedImageOptimize.gmk
@@ -39,6 +39,7 @@
  $(PACKAGES_ATTRIBUTE_TARGET): $(ALL_MODULEINFO_CLASSES) 
$(BUILD_JIGSAW_CLASSES)
      $(call LogInfo, Optimizing the exploded image)
      $(TOOL_ADD_PACKAGES_ATTRIBUTE) $(JDK_OUTPUTDIR)
+    $(TOUCH) $@

  TARGETS := $(PACKAGES_ATTRIBUTE_TARGET)


/Erik




More information about the build-dev mailing list