RFR 8163320: JAVA_VERSION in release file should come from	java.base module
    Mandy Chung 
    mandy.chung at oracle.com
       
    Fri Sep  9 15:37:11 UTC 2016
    
    
  
Looks good.
Is there an existing test to check the content of `release` file?  It would be good to have a test to sanity test a few properties and its quoted value.
Mandy
> On Sep 9, 2016, at 6:02 AM, Sundararajan Athijegannathan <sundararajan.athijegannathan at oracle.com> wrote:
> 
> Please review fix for https://bugs.openjdk.java.net/browse/JDK-8163320
> 
> jdk repo:
> 
> http://cr.openjdk.java.net/~sundar/8163320/jdk/
> 
> * JAVA_VERSION is derived from module-info of java.base
> 
> * adding quotes around all 'release' properties
> 
> top repo:
> 
> http://cr.openjdk.java.net/~sundar/8163320/top/webrev.01/
> 
> Makefile changes to avoid generating OS_NAME, JAVA_VERSION etc. - as
> jlink takes care of those.
> 
> Thanks
> 
> -Sundar
> 
    
    
More information about the build-dev
mailing list