RFR: 8166189: Fix for Bug 8165524 breaks AIX build

[Chris Bensen]

A lot of ideas have been thrown around so solve the problem of duplicated code in this situation. And there are other cases that are nearly identical so we need a general solution. The fact is this code should be moved to a common location. Since OpenJDK depends on Posix, Windows API and a few other non standard things that are mostly standard such as dladdr, it has been suggested by me and others that a library that doesn’t depend on anything else be created containing these methods to backfill the API that OpenJDK depends on if that API is not present on that platform. If that is a library outside OpenJDK or inside I’m not sure if that matters. Fact is there should be a library that contains method such as dladdr in cases such as AIX that do not have that method. Personally I’m not sure if the hack implementation of dladdr for AIX should be located in OpenJDK.

Chris


> On Sep 29, 2016, at 8:25 AM, Erik Joelsson <erik.joelsson at oracle.com> wrote:
> 
> 
> 
> On 2016-09-29 16:54, Alan Burlison wrote:
>> On 29/09/2016 08:03, Volker Simonis wrote:
>> 
>>> Sorry, but that doesn't sound like a solution to me at all. I think we
>>> should keep the OpenJDK sources self-contained. I don't want to depend
>>> on yet another non-standard, third party library which doesn't even
>>> exist now.
>> 
>> Unless I'm completely misunderstanding, that's not what is being proposed. What is being proposed is refactoring code that's currently duplicated across the JVM & JDK into a common library. Such a library would be a standard Java component, not non-standard and not third-party. I can't see what the problem is, to be honest.
>> 
> Volker's comment above was directed at the suggestion of taking the problematic AIX specific code out of the OpenJDK repositories and create a separate library with a separate lifecycle somewhere else that OpenJDK for AIX would then need to depend on. Volker was instead proposing what you describe.
> 
> /Erik