RFR: 8173801 Remove non-client demos and samples
Magnus Ihse Bursie
magnus.ihse.bursie at oracle.com
Tue Apr 11 08:19:29 UTC 2017
On 2017-04-10 09:51, Erik Joelsson wrote:
> Hello,
>
> CompileDemos.gmk: 270: The $(call install-file) line shouldn't be removed
>
> make/Bundles.gmk: 186: Since the client demos are still in there, they
> still need to be filtered out of the image when creating the JDK bundle.
>
> Otherwise this looks ok.
Agree, with these things fixed it looks good.
/Magnus
>
> /Erik
>
>
> On 2017-04-07 23:05, Alexandre (Shura) Iline wrote:
>> After some back and forth it was decided that the client demos should
>> stay intact for JDK9 and be reworked into tests as a part of another
>> JEP.
>>
>> With that, could you take another look on the suggested changes?
>> http://cr.openjdk.java.net/~shurailine/8173801/webrev.03
>>
>> Thank you.
>>
>> Shura
>>
>>
>>> On Mar 3, 2017, at 9:39 AM, Phil Race <philip.race at oracle.com> wrote:
>>>
>>> What is the plan for ensuring there is still a way to build the
>>> client demos - which are not being removed
>>> but just moved. Doesn't this makefile need to be somewhere still ?
>>>
>>> -phil.
>>>
>>> On 3/3/2017 12:18 AM, Magnus Ihse Bursie wrote:
>>>> On 2017-03-02 20:33, Alexandre (Shura) Iline wrote:
>>>>> Hi,
>>>>>
>>>>> Could you be so kind to review suggested changes for the makefiles
>>>>> to stop producing sales and demos bundle. Pls note that this
>>>>> request only changes the makefiles, it does not remove demos and
>>>>> samples source code, which will be done separately.
>>>>>
>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8173801
>>>>> Webrev: http://cr.openjdk.java.net/~shurailine/8173801/webrev.02/
>>>>>
>>>>> Shura
>>>> Looks good to me.
>>>>
>>>> Good riddance! :-)
>>>>
>>>> /Magnus
>>>>
>
More information about the build-dev
mailing list