RFR: JDK-8179078: Jib run-test-prebuilt profile missing dependency on bootjdk

Tim Bell tim.bell at oracle.com
Fri Apr 21 14:52:53 UTC 2017


Erik-

Looks good to me as well.

/Iim


On 04/21/17 07:48, Christian Tornqvist wrote:
> Hi Erik,
>
> This looks good, I’ve verified that the fix works. Thanks for fixing this!
>
> Thanks,
> Christian
>
>> On Apr 21, 2017, at 10:43 AM, Erik Joelsson <erik.joelsson at oracle.com> wrote:
>>
>> (resending to include Christian)
>>
>>
>> On 2017-04-21 16:37, Erik Joelsson wrote:
>>> Hello,
>>>
>>> When using the run-test-prebuilt Jib profile to run tests, we need to set JT_JAVA to point to the boot jdk for jtreg. The configuration to set JT_JAVA is there, but I forgot to also add boot_jdk as a dependency on that profile.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8179078
>>>
>>> Patch:
>>>
>>> diff -r 111e2e7d00f4 common/conf/jib-profiles.js
>>> --- a/common/conf/jib-profiles.js
>>> +++ b/common/conf/jib-profiles.js
>>> @@ -584,7 +584,7 @@
>>>     var testOnlyProfilesPrebuilt = {
>>>         "run-test-prebuilt": {
>>>             src: "src.conf",
>>> -            dependencies: [ "jtreg", "gnumake", testedProfile + ".jdk",
>>> +            dependencies: [ "jtreg", "gnumake", "boot_jdk", testedProfile + ".jdk",
>>>                 testedProfile + ".test", "src.full"
>>>             ],
>>>             work_dir: input.get("src.full", "install_path") + "/test",
>>>
>>>
>>> /Erik
>>>
>>
>




More information about the build-dev mailing list