CompileJavaModule.gmk overrides values from a custom extension gmk

[Gary Adams]

Is the expectation that all of the := will be changed to += for these 
variables?

  468 jdk.internal.vm.ci_ADD_JAVAC_FLAGS := -parameters -Xlint:-exports -XDstringConcat=inline

Do the closed makefiles also need to be updated?

On 8/30/17, 10:36 AM, Erik Joelsson wrote:
> Hello Jason,
>
> I took the liberty of creating an issue for this: 
> https://bugs.openjdk.java.net/browse/JDK-8186983
>
> The mailing list server removes attachments. This makes it difficult 
> for new people to send in their patches until they have an openjdk 
> user so they can upload to cr.openjdk.java.net. Since you addressed 
> the mail directly to me as well, I received the attachment and have 
> created a webrev from it here:
>
> http://cr.openjdk.java.net/~erikj/8186983/webrev.01/
>
> I think the patch looks good now, but will leave it here until 
> tomorrow to give other reviewers a chance to look at.
>
> /Erik
>
>
> On 2017-08-30 16:20, Jason Yong wrote:
>> Hi Eric,
>>
>> I've removed the SETUP changes as requested...
>>
>>
>>
>> On a side note, I noticed that the attachment got stripped out in the 
>> post
>> to the mailing list. Should I actually be copying and pasting the entire
>> diff in the message? Its a couple of hundred lines... or is somewhere to
>> put the attachment?
>>
>>
>> Regards,
>>
>> Jason Yong
>> CEng MEng MIET
>> Software Engineer, IBM Runtimes Technology
>> IBM Hybrid Cloud
>>
>>
>> Phone: 44-1962-815256
>> E-mail: yongja at uk.ibm.com
>> Find me on:  and within IBM on:
>>
>>
>> Hursley Park
>> Hursley, SO212JN
>> United Kingdom
>>
>>
>>
>>
>>
>> From:   Erik Joelsson <erik.joelsson at oracle.com>
>> To:     Jason Yong <Jason_Yong at uk.ibm.com>
>> Cc:     build-dev at openjdk.java.net
>> Date:   30/08/2017 14:43
>> Subject:        Re: CompileJavaModule.gmk overrides values from a custom
>> extension gmk
>>
>>
>>
>> Hello,
>>
>> Changing the assignment on COPY, CLEAN and FLAGS variables makes sense,
>> but please revert the SETUP variables as those are not lists but single
>> value types.
>>
>> Otherwise this looks good to me.
>>
>> /Erik
>>
>>
>> On 2017-08-30 15:37, Jason Yong wrote:
>>> Hi Eric,
>>>
>>> With regards to the OCA I believe IBM has signed a contributors
>> agreement
>>> which should cover me for that.
>>>
>>>
>>> So here's the mercurial export of the CompileJavaModule.java with my
>>> changes in
>>>
>>>
>>>
>>>
>>> Regards,
>>>
>>>
>>> Jason Yong
>>>
>>> CEng MEng MIET
>>> Software Engineer, IBM Runtimes Technology
>>> IBM Hybrid Cloud
>>>
>>>
>>> Phone: 44-1962-815256
>>> E-mail: yongja at uk.ibm.com
>>> Find me on:  and within IBM on:
>>>
>>>
>>> Hursley Park
>>> Hursley, SO212JN
>>> United Kingdom
>>>
>>>
>>>
>>>
>>>
>>> From:   Erik Joelsson <erik.joelsson at oracle.com>
>>> To:     Jason Yong <Jason_Yong at uk.ibm.com>
>>> Cc:     build-dev at openjdk.java.net
>>> Date:   30/08/2017 13:47
>>> Subject:        Re: CompileJavaModule.gmk overrides values from a 
>>> custom
>>> extension gmk
>>>
>>>
>>>
>>> If you have signed the OCA, you can post your proposed change here 
>>> and I
>>> or someone else will sponsor it once we agree that it looks good.
>>> /Erik
>>>
>>> On 2017-08-30 14:27, Jason Yong wrote:
>>> Thanks Eric,
>>>
>>> Is the next step is to get a sponsor for the change or should I post my
>>> proposed change first?
>>>
>>> Jason
>>>
>>> Regards,
>>>
>>> Jason Yong
>>> CEng MEng MIET
>>> Software Engineer, IBM Runtimes Technology
>>> IBM Hybrid Cloud
>>>
>>>
>>> Phone: 44-1962-815256
>>> E-mail: yongja at uk.ibm.com
>>> Find me on:  and within IBM on:
>>>
>>>
>>> Hursley Park
>>> Hursley, SO212JN
>>> United Kingdom
>>>
>>>
>>>
>>>
>>>
>>>
>>> From:        Erik Joelsson <erik.joelsson at oracle.com>
>>> To:        Jason Yong <Jason_Yong at uk.ibm.com>,
>> build-dev at openjdk.java.net
>>> Date:        29/08/2017 12:55
>>> Subject:        Re: CompileJavaModule.gmk overrides values from a 
>>> custom
>>> extension gmk
>>>
>>>
>>>
>>> Hello Jason,
>>>
>>> Your suggestion makes sense. The only reason these variables have :=
>>> today is that we (at Oracle) haven't had a need for appending to those
>>> particular variables (yet).
>>>
>>> /Erik
>>>
>>>
>>> On 2017-08-29 11:31, Jason Yong wrote:
>>>> Hello,
>>>>
>>>> I've had an issue where I've had a custom extension to
>>> CompileJavaModules.gmk with the variable java.base_COPY set to files
>> that
>>> I wanted to be copied across but its value was overwritten by
>>> CompileJavaModules.gmk.
>>>> I would like to propose changes that would allow a custom 
>>>> extensions to
>>> update variables listed in CompileJavaModules.gmk. This issue is 
>>> similar
>>> to bug JDK-8064372 (
>>>
>> https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8064372&d=DwICaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=_pd0JudnAMtzyOP3NkOCP7ozDRbZ9ukki8lLmogKLJI&m=qG_YEjgXnzBfNvN5ztSbjIVP3nZ5SaZCibl7SHJjTfc&s=2mMmeC6jKTJu1OgK0Lssib1LKQvOFX3BwzIcJAebSeU&e= 
>>
>>
>>> ) but affects all the other variables such as:
>>>> java.activation_SETUP
>>>> java.base_ADD_JAVAC_FLAGS
>>>> java.base_COPY
>>>> java.base_CLEAN
>>>> etc
>>>>
>>>> The fix is also similar, changing := to += allowing the custom
>> extension
>>> to append to the variable if already set and create it if its not.
>>>> I would appreciate any feedback and help on what the next steps would
>>> be.
>>>> Thanks
>>>>
>>>> Jason
>>>>
>>>>
>>>> Jason Yong
>>>> CEng MEng MIET
>>>> Software Engineer, IBM Runtime Technologies
>>>> IBM Hybrid Cloud
>>>> Phone: 44-1962-815256
>>>> E-mail: yongja at uk.ibm.com
>>>> Find me on:  and within IBM on:
>>>> Unless stated otherwise above:
>>>> IBM United Kingdom Limited - Registered in England and Wales with
>> number
>>> 741598.
>>>> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6
>>> 3AU
>>>
>>>
>>>
>>> Unless stated otherwise above:
>>> IBM United Kingdom Limited - Registered in England and Wales with 
>>> number
>>> 741598.
>>> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6
>> 3AU
>>>
>>>
>>> Unless stated otherwise above:
>>> IBM United Kingdom Limited - Registered in England and Wales with 
>>> number
>>> 741598.
>>> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6
>> 3AU
>>
>>
>>
>>
>> Unless stated otherwise above:
>> IBM United Kingdom Limited - Registered in England and Wales with number
>> 741598.
>> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire 
>> PO6 3AU
>