[RFR]: 8187004: No valid toolchains defined for BSD

[David Holmes]

On 31/08/2017 4:14 PM, Thomas Stüfe wrote:
> Hi Adrian,
> 
> this looks fine. Thanks for taking on BSD (I'm a bit confused though, I
> thought BSD is already buildable).

Thomas you beat me to it - on both counts! I too recall others building 
for BSD.

David

> Best Regards, Thomas
> 
> On Wed, Aug 30, 2017 at 10:30 PM, John Paul Adrian Glaubitz <
> glaubitz at physik.fu-berlin.de> wrote:
> 
>> Hello!
>>
>> I started working on fixing OpenJDK on BSD today and already ran into
>> the first issue which is the configure script being unable to find a
>> usable toolchain.
>>
>> This happens because there are no valid toolchains defined for BSD in
>> common/autoconf/toolchain.m4. Since both clang and gcc are supported
>> on most BSD systems, this can be trivially resolved with:
>>
>> diff -r 1147dee33745 common/autoconf/toolchain.m4
>> --- a/common/autoconf/toolchain.m4      Tue Aug 29 17:17:57 2017 +0200
>> +++ b/common/autoconf/toolchain.m4      Wed Aug 30 22:22:49 2017 +0200
>> @@ -42,6 +42,7 @@
>>   VALID_TOOLCHAINS_macosx="gcc clang"
>>   VALID_TOOLCHAINS_aix="xlc"
>>   VALID_TOOLCHAINS_windows="microsoft"
>> +VALID_TOOLCHAINS_bsd="gcc clang"
>>    # Toolchain descriptions
>>   TOOLCHAIN_DESCRIPTION_clang="clang/LLVM"
>>
>> Webrev can be found in [1].
>>
>> Adrian
>>
>> [1] http://cr.openjdk.java.net/~glaubitz/8187004/webrev.00/
>>>
>>
>> --
>>   .''`.  John Paul Adrian Glaubitz
>> : :' :  Debian Developer - glaubitz at debian.org
>> `. `'   Freie Universitaet Berlin - glaubitz at physik.fu-berlin.de
>>    `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913
>>