[RFR]: 8187004: No valid toolchains defined for BSD

[David Holmes]

On 31/08/2017 4:41 PM, Thomas Stüfe wrote:
> Looking through my Mails quick, all mails at bsd-port-dev seem to refer 
> to jdk8.

Yes the port went dormant after 8.

> toolchain.m4 changed a bit since jdk8. Maybe noone attempted to build 
> jdk10 yet on BSD and Adrian ran into new errors.

Did some digging. Magnus was trying to drum up support to resurrect the 
BSD port in 9:

http://mail.openjdk.java.net/pipermail/build-dev/2016-January/016421.html
http://cr.openjdk.java.net/~ihse/JDK-8147795-build-system-support-for-bsd/webrev.01/

but that didn't happen. As you can see from Magnus's patches there is a 
lot more to it than just fixing the valid toolchains.

David
-----

> 
> ..Thomas
> 
> On Thu, Aug 31, 2017 at 8:25 AM, David Holmes <david.holmes at oracle.com 
> <mailto:david.holmes at oracle.com>> wrote:
> 
>     On 31/08/2017 4:14 PM, Thomas Stüfe wrote:
> 
>         Hi Adrian,
> 
>         this looks fine. Thanks for taking on BSD (I'm a bit confused
>         though, I
>         thought BSD is already buildable).
> 
> 
>     Thomas you beat me to it - on both counts! I too recall others
>     building for BSD.
> 
>     David
> 
> 
>         Best Regards, Thomas
> 
>         On Wed, Aug 30, 2017 at 10:30 PM, John Paul Adrian Glaubitz <
>         glaubitz at physik.fu-berlin.de
>         <mailto:glaubitz at physik.fu-berlin.de>> wrote:
> 
>             Hello!
> 
>             I started working on fixing OpenJDK on BSD today and already
>             ran into
>             the first issue which is the configure script being unable
>             to find a
>             usable toolchain.
> 
>             This happens because there are no valid toolchains defined
>             for BSD in
>             common/autoconf/toolchain.m4. Since both clang and gcc are
>             supported
>             on most BSD systems, this can be trivially resolved with:
> 
>             diff -r 1147dee33745 common/autoconf/toolchain.m4
>             --- a/common/autoconf/toolchain.m4      Tue Aug 29 17:17:57
>             2017 +0200
>             +++ b/common/autoconf/toolchain.m4      Wed Aug 30 22:22:49
>             2017 +0200
>             @@ -42,6 +42,7 @@
>                VALID_TOOLCHAINS_macosx="gcc clang"
>                VALID_TOOLCHAINS_aix="xlc"
>                VALID_TOOLCHAINS_windows="microsoft"
>             +VALID_TOOLCHAINS_bsd="gcc clang"
>                 # Toolchain descriptions
>                TOOLCHAIN_DESCRIPTION_clang="clang/LLVM"
> 
>             Webrev can be found in [1].
> 
>             Adrian
> 
>             [1] http://cr.openjdk.java.net/~glaubitz/8187004/webrev.00/
>             <http://cr.openjdk.java.net/~glaubitz/8187004/webrev.00/>
> 
> 
> 
>             --
>                .''`.  John Paul Adrian Glaubitz
>             : :' :  Debian Developer - glaubitz at debian.org
>             <mailto:glaubitz at debian.org>
>             `. `'   Freie Universitaet Berlin -
>             glaubitz at physik.fu-berlin.de
>             <mailto:glaubitz at physik.fu-berlin.de>
>                 `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5
>             F913
> 
>