RFR(M): 8186978: Introduce configure argument enable-cds

[David Holmes]

Hi Goetz,

On 31/08/2017 10:29 PM, Lindenmaier, Goetz wrote:
> Hi,
> 
> Tests for class data sharing (cds) are enabled if @requires vm.cds is true.
> The property vm.cds depends on the preprocessor macro ENABLE_CDS.
> This can not yet be switched by configure. It's only disabled automatically
> for the minimal build.
> 
> This change introduces enable-cds with default true, which only takes effect
> in the non-minimal build. If disabled, generate-classlist is disabled, too.
> 
> Please review this change. I please need a sponsor.
> http://cr.openjdk.java.net/~goetz/wr17/8186978-disableCDS/webrev.01/index.html

I'll let the build guys comment in detail, but the structure for this 
doesn't quite look right to me. I don't understand why you have in 
spec.gmk.in:

+ ENABLE_CDS:=@ENABLE_CDS@

when in the hotspot build CDS is controlled via the feature setting:

ifneq ($(call check-jvm-feature, cds), true)

which you are already handling. ??

Thanks,
David


> Best regards,
>    Goetz.
>